feat - support readDirectory for ADT#18
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a workspace/readDirectory JSON-RPC handler to the Eclipse language client, enabling directory listing for ADT/virtual URIs by introducing a new protocol result type and implementing directory enumeration via Eclipse resources.
Changes:
- Added
workspace/readDirectoryrequest handler inCopilotLanguageClient. - Implemented
FileUtils.readDirectoryEntries(...)to enumerateIContainermembers and map them to file-type codes. - Introduced
ReadDirectoryResultprotocol DTO for returning directory entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/utils/FileUtils.java | Adds directory enumeration utility backing workspace/readDirectory. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/protocol/ReadDirectoryResult.java | New protocol result type for directory entry listings. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageClient.java | Exposes workspace/readDirectory JSON-RPC endpoint delegating to FileUtils. |
jdneo
reviewed
Apr 22, 2026
jdneo
previously approved these changes
Apr 22, 2026
ethanyhou
requested changes
Apr 22, 2026
ethanyhou
reviewed
Apr 22, 2026
ethanyhou
requested changes
Apr 22, 2026
… into tori/supportListDir
jdneo
previously approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.